fix(js): update exec security test for sandbox-safe exec behavior#851
Merged
fix(js): update exec security test for sandbox-safe exec behavior#851
Conversation
PR #815 made `exec cmd` run within VFS sandbox instead of blocking. The JS security test still expected `exec ls` to fail, but `ls` is a builtin that succeeds in the sandbox. Changed to test `exec /bin/bash` which correctly fails (external binary not in VFS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec cmdto run within VFS sandbox instead of blockingexec lsnow succeeds (exit 0) sincelsis a valid builtin in the sandboxexec /bin/bashwhich correctly fails (external binary not in VFS)Test plan
cargo test --all-features)cargo fmt --checkandcargo clippyclean